badjware
/
the-algorithm
mirror of https://github.com/twitter/the-algorithm.git
1
0
Fork 0
Code Releases Activity

refine with static list 

1. refine with static varirable, instead of compare value one by one
This commit is contained in:
DESKTOP-MIRQB93\user 2023-04-05 17:22:21 +08:00
parent 138bb51997
commit 1581a014a2
1 changed files with 8 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
src/java/com/twitter/search/common/util/earlybird/EarlybirdResponseUtil.java
View File

@ -22,6 +22,12 @@ import com.twitter.search.earlybird.thrift.ThriftTweetSource;
/** Utility methods that work on EarlybirdResponses. */ /** Utility methods that work on EarlybirdResponses. */
public final class EarlybirdResponseUtil { public final class EarlybirdResponseUtil {
static private List<EarlybirdResponseCode> successfulResponseCodeList
= Arrays.asList(EarlybirdResponseCode.SUCCESS,
EarlybirdResponseCode.TIER_SKIPPED,
EarlybirdResponseCode.REQUEST_BLOCKED_ERROR);
private EarlybirdResponseUtil() { private EarlybirdResponseUtil() {
} }
@ -77,9 +83,7 @@ public final class EarlybirdResponseUtil {
* Returns if the response should be considered failed for purposes of stats and logging. * Returns if the response should be considered failed for purposes of stats and logging.
*/ */
public static boolean responseConsideredFailed(EarlybirdResponseCode code) { public static boolean responseConsideredFailed(EarlybirdResponseCode code) {
return code != EarlybirdResponseCode.SUCCESS return !successfulResponseCodeList.contains(code);
&& code != EarlybirdResponseCode.REQUEST_BLOCKED_ERROR
&& code != EarlybirdResponseCode.TIER_SKIPPED;
} }
/** /**
@ -171,9 +175,7 @@ public final class EarlybirdResponseUtil {
*/ */
public static boolean isSuccessfulResponse(EarlybirdResponse response) { public static boolean isSuccessfulResponse(EarlybirdResponse response) {
return response != null return response != null
&& (response.getResponseCode() == EarlybirdResponseCode.SUCCESS && successfulResponseCodeList.contains(response.getResponseCode());
|| response.getResponseCode() == EarlybirdResponseCode.TIER_SKIPPED
|| response.getResponseCode() == EarlybirdResponseCode.REQUEST_BLOCKED_ERROR);
} }
/** /**