From 54f8db57498d3d5998121716ff8049d4a0d3398e Mon Sep 17 00:00:00 2001 From: theSEXYbastard <129617932+theSEXYbastard@users.noreply.github.com> Date: Sat, 1 Apr 2023 21:01:21 +0300 Subject: [PATCH] Refactor: avoid magic numbers and hardcoded values --- .../index/EarlybirdRealtimeIndexSegmentAtomicReader.java | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/src/java/com/twitter/search/core/earlybird/index/EarlybirdRealtimeIndexSegmentAtomicReader.java b/src/java/com/twitter/search/core/earlybird/index/EarlybirdRealtimeIndexSegmentAtomicReader.java index 78c1f6d45..e80324b2e 100644 --- a/src/java/com/twitter/search/core/earlybird/index/EarlybirdRealtimeIndexSegmentAtomicReader.java +++ b/src/java/com/twitter/search/core/earlybird/index/EarlybirdRealtimeIndexSegmentAtomicReader.java @@ -37,14 +37,17 @@ public final class EarlybirdRealtimeIndexSegmentAtomicReader */ EarlybirdRealtimeIndexSegmentAtomicReader(EarlybirdRealtimeIndexSegmentData segmentData) { super(segmentData); - + + final int initialMaxDocId = Integer.MAX_VALUE; + this.fields = new InMemoryFields(segmentData.getPerFieldMap(), syncData.getIndexPointers()); // We cache the highest doc ID and the number of docs, because the reader must return the same // values for its entire lifetime, and the segment will get more tweets over time. // These values could be slightly out of sync with 'fields', because we don't update these // values atomically with the fields. - this.maxDocId = segmentData.getDocIDToTweetIDMapper().getPreviousDocID(Integer.MAX_VALUE); + int initialMaxDocId = Integer.MAX_VALUE; + this.maxDocId = segmentData.getDocIDToTweetIDMapper().getPreviousDocID(initialMaxDocId); this.numDocs = segmentData.getDocIDToTweetIDMapper().getNumDocs(); }