From 97fd2dc82123e1d15770c41fa2f97a4df3a567e1 Mon Sep 17 00:00:00 2001
From: pedroluiznogueira <peluiznogueiram@hotmail.com>
Date: Sat, 1 Apr 2023 01:39:53 -0300
Subject: [PATCH] feat: reduce duplication in BasicIndexingConverter

---
 .../converter/earlybird/BasicIndexingConverter.java      | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/java/com/twitter/search/common/converter/earlybird/BasicIndexingConverter.java b/src/java/com/twitter/search/common/converter/earlybird/BasicIndexingConverter.java
index 2cfc3b986..5966805a5 100644
--- a/src/java/com/twitter/search/common/converter/earlybird/BasicIndexingConverter.java
+++ b/src/java/com/twitter/search/common/converter/earlybird/BasicIndexingConverter.java
@@ -560,10 +560,11 @@ public class BasicIndexingConverter {
           long inReplyToUserIdVal,
           boolean strict,
           EarlybirdThriftDocumentBuilder builder) {
-    Optional<Long> retweetUserId = Optional.of(retweetUserIdVal).filter(id -> id > 0);
-    Optional<Long> sharedStatusId = Optional.of(sharedStatusIdVal).filter(id -> id > 0);
-    Optional<Long> inReplyToUserId = Optional.of(inReplyToUserIdVal).filter(id -> id > 0);
-    Optional<Long> inReplyToStatusId = Optional.of(inReplyToStatusIdVal).filter(id -> id > 0);
+    Predicate<Long> isGreaterThanZero = id -> id > 0;
+    Optional<Long> retweetUserId = Optional.of(retweetUserIdVal).filter(isGreaterThanZero);
+    Optional<Long> sharedStatusId = Optional.of(sharedStatusIdVal).filter(isGreaterThanZero);
+    Optional<Long> inReplyToUserId = Optional.of(inReplyToUserIdVal).filter(isGreaterThanZero);
+    Optional<Long> inReplyToStatusId = Optional.of(inReplyToStatusIdVal).filter(isGreaterThanZero);
 
     Preconditions.checkState(retweetUserId.isPresent() == sharedStatusId.isPresent());