badjware
/
the-algorithm
mirror of https://github.com/twitter/the-algorithm.git
1
0
Fork 0
Code Releases Activity

update: removed unused variable

This commit is contained in:
michaelg 2023-04-01 15:45:02 +01:00
parent ec83d01dca
commit 9bc72e82b2
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/java/com/twitter/search/feature_update_service/FeatureUpdateController.java
View File

@ -130,7 +130,7 @@ public class FeatureUpdateController implements FeatureUpdateService.ServiceIfac
} }
ThriftIndexingEvent event = featureUpdate.getEvent(); ThriftIndexingEvent event = featureUpdate.getEvent();
return writeToKafka(event, requestStartTimeMillis) return writeToKafka(event)
.map(responsesList -> { .map(responsesList -> {
stats.clientResponse(requestClientId, FeatureUpdateResponseCode.SUCCESS); stats.clientResponse(requestClientId, FeatureUpdateResponseCode.SUCCESS);
// only when both Realtime & RealtimeCG succeed, then it will return a success flag // only when both Realtime & RealtimeCG succeed, then it will return a success flag
@ -162,8 +162,7 @@ public class FeatureUpdateController implements FeatureUpdateService.ServiceIfac
* The FeatureUpdateResponse is more like an ACK message, and the upstream (feature update ingester) * The FeatureUpdateResponse is more like an ACK message, and the upstream (feature update ingester)
* will not be affected much even if it failed (as long as the kafka message is written) * will not be affected much even if it failed (as long as the kafka message is written)
*/ */
private Future<List<BoxedUnit>> writeToKafka(ThriftIndexingEvent event, private Future<List<BoxedUnit>> writeToKafka(ThriftIndexingEvent event) {
long requestStartTimeMillis) {
return Futures.collect(Lists.newArrayList( return Futures.collect(Lists.newArrayList(
writeToKafkaInternal(event, WRITE_TO_KAFKA_DECIDER_KEY, droppedKafkaUpdateEvents, writeToKafkaInternal(event, WRITE_TO_KAFKA_DECIDER_KEY, droppedKafkaUpdateEvents,
kafkaUpdateEventsTopicName, -1, kafkaProducer), kafkaUpdateEventsTopicName, -1, kafkaProducer),