From a7fd896befcd0d7e64d489f3e1678985a37a6c38 Mon Sep 17 00:00:00 2001 From: Daira Emma Hopwood Date: Sun, 2 Apr 2023 02:49:43 +0100 Subject: [PATCH] Disable the "out of network" scoring penalty. Signed-off-by: Daira Emma Hopwood --- .../scorer/OONTweetScalingScorer.scala | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/home-mixer/server/src/main/scala/com/twitter/home_mixer/functional_component/scorer/OONTweetScalingScorer.scala b/home-mixer/server/src/main/scala/com/twitter/home_mixer/functional_component/scorer/OONTweetScalingScorer.scala index 4b1cec4a5..005154c99 100644 --- a/home-mixer/server/src/main/scala/com/twitter/home_mixer/functional_component/scorer/OONTweetScalingScorer.scala +++ b/home-mixer/server/src/main/scala/com/twitter/home_mixer/functional_component/scorer/OONTweetScalingScorer.scala @@ -22,7 +22,7 @@ object OONTweetScalingScorer extends Scorer[PipelineQuery, TweetCandidate] { override val features: Set[Feature[_, _]] = Set(ScoreFeature) - private val ScaleFactor = 0.75 + private val ScaleFactor = 1.0 override def apply( query: PipelineQuery, @@ -38,11 +38,9 @@ object OONTweetScalingScorer extends Scorer[PipelineQuery, TweetCandidate] { } /** - * We should only be applying this multiplier to Out-Of-Network tweets. - * In-Network Retweets of Out-Of-Network tweets should not have this multiplier applied + * Don't apply this multiplier; it's a bad idea. */ private def selector(candidate: CandidateWithFeatures[TweetCandidate]): Boolean = { - !candidate.features.getOrElse(InNetworkFeature, false) && - !candidate.features.getOrElse(IsRetweetFeature, false) + false } }