badjware
/
the-algorithm
mirror of https://github.com/twitter/the-algorithm.git
1
0
Fork 0
Code Releases Activity

feat: reduce duplication in BasicIndexingConverter

This commit is contained in:
pedroluiznogueira 2023-04-01 01:39:53 -03:00
parent eaeb4bc1d8
commit 97fd2dc821
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/java/com/twitter/search/common/converter/earlybird/BasicIndexingConverter.java
View File

@ -560,10 +560,11 @@ public class BasicIndexingConverter {
long inReplyToUserIdVal, long inReplyToUserIdVal,
boolean strict, boolean strict,
EarlybirdThriftDocumentBuilder builder) { EarlybirdThriftDocumentBuilder builder) {
Optional<Long> retweetUserId = Optional.of(retweetUserIdVal).filter(id -> id > 0); Predicate<Long> isGreaterThanZero = id -> id > 0;
Optional<Long> sharedStatusId = Optional.of(sharedStatusIdVal).filter(id -> id > 0); Optional<Long> retweetUserId = Optional.of(retweetUserIdVal).filter(isGreaterThanZero);
Optional<Long> inReplyToUserId = Optional.of(inReplyToUserIdVal).filter(id -> id > 0); Optional<Long> sharedStatusId = Optional.of(sharedStatusIdVal).filter(isGreaterThanZero);
Optional<Long> inReplyToStatusId = Optional.of(inReplyToStatusIdVal).filter(id -> id > 0); Optional<Long> inReplyToUserId = Optional.of(inReplyToUserIdVal).filter(isGreaterThanZero);
Optional<Long> inReplyToStatusId = Optional.of(inReplyToStatusIdVal).filter(isGreaterThanZero);
Preconditions.checkState(retweetUserId.isPresent() == sharedStatusId.isPresent()); Preconditions.checkState(retweetUserId.isPresent() == sharedStatusId.isPresent());