badjware
/
the-algorithm
mirror of https://github.com/twitter/the-algorithm.git
1
0
Fork 0
Code Releases Activity

Disable the "out of network" scoring penalty. 

Signed-off-by: Daira Emma Hopwood <daira@jacaranda.org>
This commit is contained in:
Daira Emma Hopwood 2023-04-02 02:49:43 +01:00
parent ec83d01dca
commit a7fd896bef
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
home-mixer/server/src/main/scala/com/twitter/home_mixer/functional_component/scorer/OONTweetScalingScorer.scala
View File

@ -22,7 +22,7 @@ object OONTweetScalingScorer extends Scorer[PipelineQuery, TweetCandidate] {
override val features: Set[Feature[_, _]] = Set(ScoreFeature) override val features: Set[Feature[_, _]] = Set(ScoreFeature)
private val ScaleFactor = 0.75 private val ScaleFactor = 1.0
override def apply( override def apply(
query: PipelineQuery, query: PipelineQuery,
@ -38,11 +38,9 @@ object OONTweetScalingScorer extends Scorer[PipelineQuery, TweetCandidate] {
} }
/** /**
* We should only be applying this multiplier to Out-Of-Network tweets. * Don't apply this multiplier; it's a bad idea.
* In-Network Retweets of Out-Of-Network tweets should not have this multiplier applied
*/ */
private def selector(candidate: CandidateWithFeatures[TweetCandidate]): Boolean = { private def selector(candidate: CandidateWithFeatures[TweetCandidate]): Boolean = {
!candidate.features.getOrElse(InNetworkFeature, false) && false
!candidate.features.getOrElse(IsRetweetFeature, false)
} }
} }